sync#1041
Merged
Merged
Conversation
TEST: Add test for Triangle.to_pickle().
henrydingliu
requested review from
genedan,
jbogaardt and
kennethshsu
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## disposal_rate_method #1041 +/- ##
========================================================
+ Coverage 89.17% 89.38% +0.20%
========================================================
Files 89 91 +2
Lines 5165 5266 +101
Branches 661 678 +17
========================================================
+ Hits 4606 4707 +101
+ Misses 392 391 -1
- Partials 167 168 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Related GitHub Issue(s)
Additional Context for Reviewers
uv run pytest) and documentation changes (uv run jb build docs --builder=custom --custom-builder=doctest)Note
Low Risk
Small refactor plus I/O test coverage;
Developmentkeeps its own three-argument_param_property, so incremental behavior should follow the moved helper unchanged.Overview
Triangle pickle I/O is documented at the module level in
chainladder/core/io.py, with imports reordered and an unusedjoblibimport dropped from that file (pickling still usesdill).Development estimators:
_param_propertyis added as a static helper onDevelopmentBase, and the duplicate implementation is removed fromIncrementalAdditive, which now calls the shared helper forzeta_. Type hints inDevelopmentBaseswitch fromTriangleLiketoTrianglefor_set_fit_groups.Tests:
test_triangle_to_pickleexercisesTriangle.to_pickle/read_pickleround-trips for single- and multi-dimensional sample triangles (raa,clrd).Reviewed by Cursor Bugbot for commit 468f11a. Bugbot is set up for automated code reviews on this repo. Configure here.